search

xmos / ai_tools

AI applications and tools
Other
25 stars 10 forks source link

adding compatibility with xcommon_cmake definitions #865

Closed xalbertoisorna closed 10 months ago

xalbertoisorna commented 10 months ago

xcommon_cmake uses the variable APP_BUILD_ARCH to define the architecture (xs3a). CMAKE_SYSTEM_PROCESSOR is set to XCORE_XS.

By adding xcommon_cmake usage proposed in this PR, the modification doesn't affect the old version.

Refrences: xcommon_cmake_link xcommon_cmake

xalbertoisorna commented 10 months ago

@danielpieczko please provide your feedback about this change from an xcommon_cmake point of view.

danielpieczko commented 10 months ago

This is a good way to add XCommon CMake support to the pip-installable portion of ai-tools in a backwards compatible way with existing applications that use CMake with the xmos_cmake_toolchain.