xmos / fwk_io

I/O Framework
Other
3 stars 11 forks source link

Fix test_i2s_basic_master and test_basic_master_external_clock #104

Closed shuchitak closed 9 months ago

shuchitak commented 9 months ago

https://xmosjira.atlassian.net/browse/AP-403

Changes in this PR:

pytest lib_i2s/test_i2s_basic_master.py pytest lib_i2s/test_basic_master_external_clock.py

pytest lib_i2s/test_i2s_basic_master.py --nightly pytest lib_i2s/test_basic_master_external_clock.py --nightly

Note that the mclk frequency is set such that the mclk_bclk_ratio is atleast 2 for the worst case (192KHz). I could not get the test to pass reliably if testing with mclk_bclk_ratio set to 1. Sometimes, the bclk clock block would start with a falling edge instead of a rising edge, causing the LR clk to start before the bclk. With mclk_bclk_ratio of 2 or more, I couldn't recreate this issue.

shuchitak commented 9 months ago

Looking good, assuming they all pass!

Yes! Passing consistently on my Mac.