Closed danielpieczko closed 7 months ago
While I'm here - use AssertiveComparisonTester
rather than ComparisonTester
, as that's what PytestComparisonTester
was renamed to
This issue is now tracked in Jira AP-352. I have closed the issue here since it only pertains to XMOS internal testing.
To reproduce on a Linux host, no hardware required:
pytest lib_i2c -n auto
Outcome: all tests that are run will fail with
AttributeError: module 'Pyxsim.testers' has no attribute 'PytestComparisonTester'
The test_support submodule is version 2d6a6b9 (current head of develop) and searching through that repo there is no
PytestComparisonTester
method. Changing all instances ofPytestComparisonTester
toComparisonTester
results in the tests running successfully.But the github actions job on the head of develop has not failed - I manually triggered a new job to make sure, and the tests all passed. I don't know enough about docker containers to understand what the contents really are. The github actions job launches the tests using the following command-line:
I believe this is mounting the github workspace (which has checked out the head of develop of fwk_io with commit 2d6a6b9 for the test_support submodule) inside the docker container at the path
/fwk_io
, and then running the test script from the working directory/fwk_io/test
- which should be the expected code that you want to run for the CI job. So how does that pass when a manual run outside of docker fails?So there are (at least) two questions: