search

xmos / fwk_voice

Voice Framework
Other
11 stars 19 forks source link

Use shared adaptive filter in lib_ic #362

Closed hughhop closed 1 year ago

mbanth commented 2 years ago

I'm unsure of the purpose or scope of this issue since lib_interference_canceller already uses a shared adaptive filter implementation, namely the one in the Voice Toolbox (lib_voice_toolbox). Given that lib_interference_canceller is only used in applications that are either in maintenance phase or soon will be, I do not see a business case to enhance this implementation of the IC.

hughhop commented 2 years ago

i dont think there will be any changes to lib_interference_canceller (as in the old separate repo) is that what you mean?

this is about fwk_voice/modules/lib_ic using the shared adaptive filter as described in issue 356

@uvvpavel maybe you can comment about how this relates to the generic adaptive filter in lib_voice_toolbiox

mbanth commented 2 years ago

i dont think there will be any changes to lib_interference_canceller (as in the old separate repo) is that what you mean?

this is about fwk_voice/modules/lib_ic using the shared adaptive filter as described in issue 356

I understand now. I mis-interpreted 'lib_ic' to mean the old lib_interference_canceller.

mbanth commented 1 year ago

A review by @andrewdewhurst and myself has concluded that we will not work on this issue.