xmos / lib_device_control

xCORE device control library
Other
2 stars 16 forks source link

Fixed usage pause_short() on xScope host application #43

Closed lucianomartin closed 6 years ago

lucianomartin commented 6 years ago
larry-xmos commented 6 years ago

Thanks

This is continuation of #41 and #42. It looks like across those three pull requests the only change against 3.2.0rc5 is adding a pause_short to the version query.

I'd like to spot check that this works on Mac please before merging

Also, since this will be done post release, we'll need to increment version number and add a note in changelog

larry-xmos commented 6 years ago

For completeness, could you resolve bug 17871 please and link to this pull request. That bugzilla will be referenced by VocalFusion readme so we'll want to be able to track down the fix.

xross commented 6 years ago

As of commit https://github.com/xmos/lib_device_control/commit/999b868a197415fcd221929b618c2e2a7d2adb49

pause_short is

void pause_short(void) { Sleep(0); }

i.e. no time for WIN32 and !WIN32

larry-xmos commented 6 years ago

Luciano, in Bugzilla could you please set bug 17871 to RESOLVED MOVED and post a comment with URL to this pull request

larry-xmos commented 6 years ago

Thanks, that looks good to go