search

xmos / lib_ethernet

Ethernet MAC library
Other
3 stars 12 forks source link

Poor signed/unsigned comparisons #16

Closed ahogen closed 6 years ago

ahogen commented 7 years ago

Pulled v3.3.0 from XMOS website. Building with -Wall -Wextra reveals some bad comparisons going on under the hood...

comparison between signed and unsigned  mii_ethernet_mac.xc /lib_ethernet/src   line 51 C/C++ Problem
comparison between signed and unsigned  mii_ethernet_mac.xc /lib_ethernet/src   line 73 C/C++ Problem
comparison between signed and unsigned  mii_ethernet_mac.xc /lib_ethernet/src   line 61 C/C++ Problem
comparison of unsigned expression < 0 is always false   mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 411    C/C++ Problem
comparison of unsigned expression < 0 is always false   mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 403    C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 456    C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 444    C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 481    C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 457    C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 31 C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 72 C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 55 C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 116    C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 280    C/C++ Problem
comparison between signed and unsigned  mii_ethernet_rt_mac.xc  /lib_ethernet/src   line 184    C/C++ Problem
comparison between signed and unsigned  mii_ethernet_mac.xc /lib_ethernet/src   line 77 C/C++ Problem
comparison of unsigned expression < 0 is always false   rgmii_buffering.xc  /lib_ethernet/src   line 819    C/C++ Problem
comparison of unsigned expression < 0 is always false   rgmii_buffering.xc  /lib_ethernet/src   line 829    C/C++ Problem
comparison between signed and unsigned  rgmii_buffering.xc  /lib_ethernet/src   line 573    C/C++ Problem
comparison between signed and unsigned  rgmii_buffering.xc  /lib_ethernet/src   line 581    C/C++ Problem
comparison between signed and unsigned  rgmii_buffering.xc  /lib_ethernet/src   line 711    C/C++ Problem
comparison between signed and unsigned  rgmii_buffering.xc  /lib_ethernet/src   line 288    C/C++ Problem
comparison between signed and unsigned  rgmii_buffering.xc  /lib_ethernet/src   line 328    C/C++ Problem
comparison between signed and unsigned  rgmii_buffering.xc  /lib_ethernet/src   line 493    C/C++ Problem
comparison between signed and unsigned  mii_lite_driver.xc  /lib_ethernet/src   line 224    C/C++ Problem
comparison between signed and unsigned  rgmii_buffering.xc  /lib_ethernet/src   line 275    C/C++ Problem
comparison between signed and unsigned  client_state.xc /lib_ethernet/src   line 18 C/C++ Problem
comparison between signed and unsigned  client_state.xc /lib_ethernet/src   line 6  C/C++ Problem
unused parameter `c'    mii_master.xc   /lib_ethernet/src   line 168    C/C++ Problem
comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]    macaddr_filter_hash.c   /lib_ethernet/src   line 181    C/C++ Problem
comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]    macaddr_filter_hash.c   /lib_ethernet/src   line 46 C/C++ Problem
unused parameter `c_notif'  mii.xc  /lib_ethernet/src   line 13 C/C++ Problem