search

xmos / lib_sw_pll

Software Phase Locked Loop
Other
2 stars 5 forks source link

Extend tests to exercise the BCLK adjustment argument #20

Open xhuw opened 1 year ago

xhuw commented 1 year ago

Current tests don't use BCLK adjustment. Would be nice to test this feature.

mbanth commented 1 year ago

@xhuw, please provide a Story Point value for this issue.

ed-xmos commented 1 year ago

It seems this is being done already so I think we can close this.

Edit - we do exercise the logic path that checks this but we don't specifically test scaling of anything other that 1.0.

mbanth commented 1 year ago

It seems this is being done already so I think we can close this.

Edit - we do exercise the logic path that checks this but we don't specifically test scaling of anything other that 1.0.

@xhuw, do you agree with @ed-xmos or think that further tests are needed?

xhuw commented 1 year ago

@mbanth it would be good to test this feature explicitly. I didn't originally because it seemed like more effort than it was worth, but it would have caught an issue we found on Ed's branch quicker yesterday if I had put the test in. quite low priority I think though as the tests do already get good coverage.

mbanth commented 1 year ago

@mbanth it would be good to test this feature explicitly. I didn't originally because it seemed like more effort than it was worth, but it would have caught an issue we found on Ed's branch quicker yesterday if I had put the test in. quite low priority I think though as the tests do already get good coverage.

Thanks @xhuw for your opinion. Based on it, I will leave this issue open and in your name as part of the HRK7 deliverable and with 'Should' priority.