search

xmos / lib_xcore_math

XMOS optimised arithmetic and vector processing library
Other
6 stars 14 forks source link

Remove Winndos warnings for lib source files #158

Closed lucianomartin closed 1 year ago

lucianomartin commented 1 year ago

I will remove the warnings in the tests and demos in a separate PR.

Part of https://xmosjira.atlassian.net/browse/AP-179

lucianomartin commented 1 year ago

As far as I saw we still have -Wextra and -Werror not applied to the windows build. Should we enable them back?

On windows -Wextra and -Werror are not valid, at least on my CL compiler. Do you expect them to be used on Windows?

uvvpavel commented 1 year ago

As far as I saw we still have -Wextra and -Werror not applied to the windows build. Should we enable them back?

On windows -Wextra and -Werror are not valid, at least on my CL compiler. Do you expect them to be used on Windows?

I don't really see a point in cleaning up the warnings and not enabling the -Werror, they will come back and no one's gonna notice that

lucianomartin commented 1 year ago

As far as I saw we still have -Wextra and -Werror not applied to the windows build. Should we enable them back?

On windows -Wextra and -Werror are not valid, at least on my CL compiler. Do you expect them to be used on Windows?

I don't really see a point in cleaning up the warnings and not enabling the -Werror, they will come back and no one's gonna notice that

good point. On Windows we can use -WX to treat all warnings as errors. I will enable that flag in a future PR.