search

xmos / lib_xua

XMOS USB Audio
Other
17 stars 15 forks source link

Build fail with PDM mics enabled #407

Closed xross closed 3 months ago

xross commented 4 months ago

From user:

I think I found a bug in sw_usb_audio 8.0.0 and 8.1.0. In lib_xua/lib_xua/src/core/main.xc, line 639 (8.0.0) Line 637 (8.1.0)

it says

if (XUA_NUM_PDM_MICS > 0)

endif

but it should be:

if (XUA_NUM_PDM_MICS > 0)

if (PDM_TILE == AUDIO_IO_TILE)

, c_ds_output

endif

, c_pdm_pcm

endif

I guess.

The bug yields an ‘ error: too few arguments to function `usb_audio_io’ if you try to use PDM mics. In sw_usb_audio 7.3.1, there is no such bug.

Liu0345 commented 4 months ago

I'm also surprised that it seems to have deleted the code for the following image

image

xross commented 3 months ago

This looks to have been erroneously removed in this commit https://github.com/xmos/lib_xua/commit/ca16467158a4ce71118213f7a1f48001b3f29508#diff-1d4846fbc4fb21cffaaf823ad4906e9769013896e17f787697a1cdb6acd302ef

xross commented 3 months ago

Fixed in #417