search

xmos / lib_xua

XMOS USB Audio
Other
17 stars 13 forks source link

Tasks on two tiles should use two unsafe master clock ports not one #55

Closed larry-xmos closed 5 years ago

larry-xmos commented 6 years ago

The use of p_mclk_in seems to rely on undefined behaviour in the compiler. There is a report of a failing application build using 14.3.3 tools release candidate.

lucianomartin commented 6 years ago

This issue is reported on the latest version of branch MAINTEN/v0.1 of lib_xua.

The error is:

/Users/lucianom/sb_master/lib_xua/lib_xua/src/core/main.xc: Error: Program on "tile[1]" contains a reference to resource "p_mclkin" not resident on that tile.

larry-xmos commented 6 years ago

It looks like the USB tile doesn't require p_mclk_in at all

xross commented 6 years ago

Unsafe pointers were uses as a temp work-around for unsafe resources not compiling with 14.3.2. All the unsafeness has subsequently been removed.

lucianomartin commented 6 years ago

Fix based on branch MAINTEN/v0.1 provided in

https://github.com/xmos/lib_xua/pull/56

xross commented 5 years ago

https://github.com/xmos/lib_xua/commit/a8562ad56a7287f77f83a8bc1e024947a2af6a04

Unsafe no longer used.