Support for Buster Raspian on RPi3 and RPi4

xmos / vocalfusion-rpi-setup

3 stars 13 forks source link

Support for Buster Raspian on RPi3 and RPi4 #23

Closed xluciano closed 4 years ago

xluciano commented 4 years ago

Detailed changes:

add support for RPi4 on I2S loader kernel module: loader/src/loader.c
update clock dividers for RPi3 to generate a 12.288MHz clock, since the RPi4 clock at 24.576MHz has glitches
add support for RPi4 on I2S clock generator: resources/clk_dac_setup/setup_mclk_bclk.c
add delay in loading I2S drivers needed for Buster on RPi3
add script compute_clock_dividers.py to compute dividers
fix indentations in resources/clk_dac_setup/setup_mclk_bclk.c

xluciano commented 4 years ago

Changes look good. I assume you have tested at 16kHz? Worth doing, even if it is a faff.

Requesting changes because looks like you forgot the changelog.

Also, an important point - how are the docs going to be updated? The change should most definitely be documented.

I have updated the CHANGELOG and tested at 16kHz. Documentation updates will probably follow.