xmos / xcommon_cmake

6 stars 5 forks source link

Documentation reordering #146

Closed danielpieczko closed 7 months ago

danielpieczko commented 7 months ago

Fixes #109

xross commented 7 months ago

I reviewed by building the doc and reading the PDF rather than looking at the changes in this PR:

I'm marking this as approved since I feel this PR can be merged as it is, but I feel these items should be addressed

Nice work :)

danielpieczko commented 7 months ago

I've addressed the comments, except the name: I've left XCommon CMake as it is. I was having second thoughts about "boilerplate" as well - I've gone for "CMake Header" in this change.