search

xmos / xcommon_cmake

6 stars 5 forks source link

Add Ninja to regression tests #176

Open xhuw opened 4 months ago

xhuw commented 4 months ago

only one test needed fixed which was using add_custom_target to generate a file in a way that was not supported by ninja, this was not an issue relating to xcommon cmake so I updated the test to use add_custom_command. This works.

xhuw commented 4 months ago

This line causes an issue in 3.21 with the ninja generator https://github.com/xmos/xcommon_cmake/blob/e2e7efb2e19f071c95ff4e26c2155b77042c12e5/xcommon.cmake#L692