search

xmos / xcore_iot

Other
30 stars 40 forks source link

Fix submodules by changing protocol to https #409

Closed robertbcalhoun closed 2 years ago

robertbcalhoun commented 2 years ago

Fixes issues xmos/xcore_sdk#435. Certain submodules of xcore_sdk also define gitmodules using ssh (modules/inferencing/lib_tflite_micro, modules/avona) ; these will have to be updated as well.

keithm-xmos commented 2 years ago

Thank you @robertbcalhoun for your contribution. We are investigating this change and considering an additional enhancement. It is possible to specify relative URLs in .gitmodules. This would allow the same auth method to be used used for the sdk repo and and submodules. So, a cloner could use https or ssh - whichever they prefer. We will investigate this in the next day or so.

robertbcalhoun commented 2 years ago

Thank you @robertbcalhoun for your contribution. We are investigating this change and considering an additional enhancement. It is possible to specify relative URLs in .gitmodules. This would allow the same auth method to be used used for the sdk repo and and submodules. So, a cloner could use https or ssh - whichever they prefer. We will investigate this in the next day or so.

This would be a nice approach. It appears that github has supported relative URLs in the web UI since March of 2021.

I did eventually succeed in recursively updating the git modules; github requires ssh authentication via a users own github account, but once authenticated, the user is authorized to download any public repository via ssh.

xmos-jmccarthy commented 2 years ago

Thanks again for the contribution @robertbcalhoun. We are rejecting this particular PR as it had additionally updated submodule commit hashes.

We will continue to track this issue and plan to address it in the future. xmos/xcore_sdk#435