xmos / xcore_iot

Other
30 stars 40 forks source link

Git submodules should be defined using https to permit cloning by non-authenticated users #435

Closed robertbcalhoun closed 1 year ago

robertbcalhoun commented 2 years ago

System information

Describe the problem Git submodules associated with xcore_sdk use ssh, which require the user's public key.

Provide the exact sequence of commands / steps that you executed before running into the problem

git clone --recurse-submodules https://github.com/xmos/xcore_sdk.git
Cloning into 'xcore_sdk'...
remote: Enumerating objects: 23034, done.
(...)
Submodule 'tinyusb_src' (git@github.com:hathach/tinyusb_src.git) registered for path 'modules/rtos/sw_services/usb/thirdparty/tinyusb_src'
Submodule 'test_support' (git@github.com:ACascarino/test_support.git) registered for path 'test/modules/test_support'
Submodule 'xmos_cmake_toolchain' (git@github.com:xmos/xmos_cmake_toolchain.git) registered for path 'tools/xmos_cmake_toolchain'
Cloning into '/home/rcalhoun/deleteme/xcore_sdk/modules/avona'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
(...)
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:xmos/xmos_cmake_toolchain.git' into submodule path '/home/rcalhoun/deleteme/xcore_sdk/tools/xmos_cmake_toolchain' failed
Failed to clone 'tools/xmos_cmake_toolchain'. Retry scheduled
Cloning into '/home/rcalhoun/deleteme/xcore_sdk/modules/avona'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:xmos/sw_avona.git' into submodule path '/home/rcalhoun/deleteme/xcore_sdk/modules/avona' failed
Failed to clone 'modules/avona' a second time, aborting

Other info or logs Switching submodule links from ssh links ("git@github.com") to https ("https://github.com/") will permit anonymous access. I will submit a pull request.

IOSAudio commented 1 year ago

Hi Guys,

I am hitting the incorrect rights on the submodules.

What is the correct way to clone this repository?

Many Thanks

Andy

AndrewCapon commented 1 year ago

Ok, I worked out what is going wrong here.

You need to add your default public ssh key into a GitHub account (.ssh/id_rsa.pub)

Then you can clone the "public" repository.

I had it set up with named ssh files (.ssh/id_rsa_githhubaccount.pub), this does not work.

keithm-xmos commented 1 year ago

Hi @AndrewCapon, I apologize that you ran into this issue. We do have plans to make modifications that will allow anonymous cloning.

keithm-xmos commented 1 year ago

Won't fix. Will revist in future if needed.