search

xmos / xcore_iot

Other
30 stars 40 forks source link

Feature/cmake ninja support #572

Closed jcarrier-xmos closed 1 year ago

jcarrier-xmos commented 1 year ago

Similar set of changes as RTOS module's changes for Ninja support.

One thing I noticed during this update was that the create_filesystem_target does not appear to be too useful. Contrary to the macro's name, it only copies a file to another location (as the comment in the macro suggests). I was considering options to make this be what calls fatfs_mkimage, or possibly getting rid of this target and adapt the existing logic that calls fatfs_mkimage to output to the desired directory. But for now, I decided to leave it as is, and see if anyone has an opinion on this.

jcarrier-xmos commented 1 year ago

Made a small correction to allow make clean to remove example_freertos_explorer_board_fat.fs. Before the holidays I was playing with the idea of having temp files such as these go in the cmake binary dir (something we still may want to consider to help with multi-config setups; such as having a Debug and Release configs coexist in their own out-of-source build-<config> folder).

keithm-xmos commented 1 year ago

The create_filesystem_target depends on the _fat.fs file so it forces the target to create the filesystem to run first. This simplified the test scripts because it provided a consistent target name that would generate the .fs file. Admittedly not the only way to do this.