Fix GTalk XMPP errors - Githubissues

mbbx6spp commented 12 years ago

Now fully working in a MUC setup on GTalk using the XMPP Hubot adapter and responding to commands nicely. Fixes two fundamental XMPP issues with the original Hubot adapter:

Only send initial empty presence stanza. Since we do not need to set to non-default value (i.e. not 'available', which is default) then no need to send a non-empty type attribute presence stanza. See 5.2 of XMPP IEFT working document.
Remove setting of from attribute from message stanza when responding to a message-based command as bot. Otherwise error is sent back by GTalk.

Note: This can be verified by using the hubot-xmpp2 (version 0.0.5) NPM package in your Hubot dependencies section of your package.json. I can unpublish the NPM package once pull request makes it into a published version of the hubot-xmpp package.

markstory commented 12 years ago

Thanks, I should have this merged in by the weekend.

markstory commented 12 years ago

Thanks again, merged in [1230dc57d37ee753ce3c98d114ede7fa74eb78d1]

mbbx6spp commented 12 years ago

Wonderful. Thanks for your speedy review and merge.

mbbx6spp commented 12 years ago

Just a note to say for any other issue readers that I have unpublished my NPM test package of hubot-xmpp2 since hubot-xmpp 0.0.7 contains these fixes. Thanks!

xmppjs / hubot-xmpp

Fix GTalk XMPP errors #13