Default user.type to 'groupchat' when undefined

xmppjs / hubot-xmpp

XMPP adapter for Hubot

181 stars 101 forks source link

Default user.type to 'groupchat' when undefined #7

Closed ejfinneran closed 12 years ago

ejfinneran commented 12 years ago

Hubot methods like messageRoom don't have any knowledge of XMPP internals and calls #send() with just id and room defined. This allows those types of requests to default to groupchat.

See here for some background: https://github.com/github/hubot/pull/208

Totally open to feedback on a better way to go about this as well.

Thanks!

markstory commented 12 years ago

Looks good, thanks for including tests :D