xmppjs / xmpp.js

XMPP for JavaScript
ISC License
2.19k stars 373 forks source link

SCRAM-SHA-1-PLUS, SCRAM-SHA-256(-PLUS), SCRAM-SHA-512(-PLUS) supports #620

Open Neustradamus opened 5 years ago

Neustradamus commented 5 years ago

After:

Can you add supports of:

You can add too:

"When using the SASL SCRAM mechanism, the SCRAM-SHA-256-PLUS variant SHOULD be preferred over the SCRAM-SHA-256 variant, and SHA-256 variants [RFC7677] SHOULD be preferred over SHA-1 variants [RFC5802]".

https://xmpp.org/extensions/inbox/hash-recommendations.html

-PLUS variants:

IMAP:

LDAP:

HTTP:

2FA:

IANA:

Linked to:

sonnyp commented 5 years ago

I don't understand. What's your point?

sonnyp commented 5 years ago

I will consider re-opening if you make the effort to explain what it is you're reporting.

Neustradamus commented 5 years ago

There is only SCRAM-SHA-1 in xmppjs: https://github.com/xmppjs/xmpp.js/blob/master/packages/sasl-scram-sha-1/index.js

There are not SCRAM-SHA-1-PLUS + SCRAM-SHA-256(-PLUS):

Neustradamus commented 3 years ago

@sonnyp: Good news, after XMPP Servers: Metronome IM, Tigase XMPP Server, Jackal IM, Mongoose IM, DJabberd git-master, Prosody 0.12.x, ejabberd 20.12 supports now new SCRAM.

Can you add the support in xmpp.js? Really important for security.

More infos:

Neustradamus commented 2 years ago

@sonnyp: Have you looked to add others SCRAM-SHA?

There are several packages on github to replace the "sasl-scram-sha-1"

Example for 256:

Neustradamus commented 2 years ago

Dear @xmppjs team, @sonnyp,

I wish you a Happy New Year 2022!

Have you looked for the standard SCRAM-SHA-256 which will be soon in Prosody IM 0.12 stable?

It is already supported with other SCRAM by DJabberd, ejabberd, Mongoose IM, M-Link, etc.

Thanks in advance.

Neustradamus commented 2 years ago

@ all: Good news, @based-a-tron has added in StropheJS.

What do you think about xmpp.js?

Neustradamus commented 1 year ago

@sonnyp: I see that you use now Prosody 0.12, can you look for SCRAM-SHA-256?

Other XMPP servers, several XMPP clients and XMPP libs have supports.

Thanks in advance.

sonnyp commented 1 year ago

@Neustradamus I know you have good intentions, but stop spamming over and over, it's tiring and doesn't help.