Doesn't handle errors for funky Unicode

xmppo / go-xmpp

Go XMPP Library (From Yasuhiro Matsumoto and based on the code from Russ Cox)

https://golang.org/

BSD 3-Clause "New" or "Revised" License

530 stars 167 forks source link

Doesn't handle errors for funky Unicode #96

Closed strugee closed 3 days ago

strugee commented 6 years ago

Hi! I've recently realized that in 42wim/matterbridge#209 I promised to file a bug upstream (here) but never did. I'm not too sure of the details of what's going on, but it seems that sending fancy Unicode caused this library to generate invalid XMPP stanzas, which then weren't properly error-handled. See the original ticket for details.

/cc @42wim

mdosch commented 8 months ago

Can you check whether that's still the case? I have added filtering of invalid Unicode and symbols illegal in XML recently. Maybe that fixed this behavior.

mdosch commented 3 days ago

As this issue is pretty old and there was no feedback I'll close this. Feel free to open a new issue if this is still an issue.