search

xmppo / node-xmpp-bosh

An XMPP BOSH & WebSocket server (connection manager) written on node.js using Javascript
https://github.com/xmppo/node-xmpp-bosh
263 stars 85 forks source link

open/close instead of stream:stream #117

Open Pitel opened 10 years ago

Pitel commented 10 years ago

This change makes it compatible with latest draft (in fact, this has been there since revison 01), where <stream:stream> and </stream:stream> has been replaced with <open/> and <close/>.

This makes it work with latest stanza.io, but probably breaks clients still relying on old <stream:stream> method.

Pitel commented 9 years ago

Ok, I've update the readme. Is this enough, or do you want more?

Gordin commented 9 years ago

Can this be merged? This would make node-xmpp-bosh work with the letast versions of stanza.io and latest HEAD of strophe.js (I want to make a new strophe.js release when this is merged) without workarounds. Also, releasing a new version with this would be nice for packaging.

kochka commented 9 years ago

Yes, a merge would be cool :+1:

ffPjrZUGXfcxuAj commented 9 years ago

It's possible not break compatibility with old stream:stream client?

Gordin commented 9 years ago

@camaran No, the new protocol is not backwards-compatible. The only thing you could do is implement both protocols, try the current one and if authentication fails try the deprecated protocol. Ideally we should just drop the deprecated protocol altogether though, all servers support the current protocol by now, node-xmpp-bosh is one of the last XMPP Servers/Proxies that still uses the deprecated protocol. @dhruvbird Is there still a reason why you are not merging this?

ffPjrZUGXfcxuAj commented 9 years ago

@Gordin for example Jappix client not support the new protocol

Gordin commented 9 years ago

@camaran Someone should file a bug with Jappix then, the old protocol is deprecated since February 2014 now… (Plus the changes on the client side are really not that big, they're just not compatible)