search

xmppo / node-xmpp-bosh

An XMPP BOSH & WebSocket server (connection manager) written on node.js using Javascript
https://github.com/xmppo/node-xmpp-bosh
263 stars 85 forks source link

Accented chars and special chars in JID #80

Closed valeriansaliou closed 11 years ago

valeriansaliou commented 11 years ago

Noticed a bug with accented chars in JID, as well as other kind of special chars. It seems that the challenge string does not match.

A friend of me had a test on Prosody's internal BOSH and there's no issue there, everything is working as expected with special char usernames.

See this XML trace sent back to me from NXB as connection error:

<body xmlns="http://jabber.org/protocol/httpbind" stream="4eae8cc9-2318-4fae-9e3b-5bdf34c85e27">
  <failure xmlns="urn:ietf:params:xml:ns:xmpp-sasl" xmlns:stream="http://etherx.jabber.org/streams" version="1.0">
    <not-authorized/>
    <text>The response provided by the client doesn't match the one we calculated.</text>
  </failure>
</body>

Running NXB v0.7.4 (npm)

valeriansaliou commented 11 years ago

Due to https://code.lightwitch.org/metronome/file/f36f1b2436bf/util/sasl/digest-md5.lua#l131 Sorry ;)

dhruvbird commented 11 years ago

No issues, I would have gotten to this on tuesday since am out. Thanks for updating.

valeriansaliou commented 11 years ago

Ok, np. Found out that it wasn't due to Metronome either. It's due to the JSJaC lib: https://github.com/sstrigler/JSJaC/issues/56