search

xmpppy / xmpppy

Python 2/3 implementation of XMPP
http://xmpppy.sourceforge.net/
GNU General Public License v3.0
101 stars 65 forks source link

auth.py type error setTagData('digest') #38

Closed smudge1977 closed 2 years ago

smudge1977 commented 3 years ago

Line 58 has a type error as sha1 needs a bytes so have wrapped in an encode('utf-8') to fix

query.setTagData('digest',sha1((owner.Dispatcher.Stream._document_attrs['id']+self.password).encode('utf-8')).hexdigest())
amotl commented 2 years ago

Hi there,

thank you for creating #32 to follow up on this topic, @Neustradamus. Also, thanks for educating us about that the digest authentication is obsolete already.

Still, may I ask @smudge1977 again if he would actually need this to be fixed anyway, maybe for any kinds of archaeological purposes? If so, maybe you could submit a pull request?

With kind regards, Andreas.

smudge1977 commented 2 years ago

Sorry just tested https://github.com/xmpppy/xmpppy/commit/e12316d1fb8e61ecaa45bb6548c77be46a984c56 and this works fine for me - thanks