issues
search
xmr-rs
/
xmr
Monero node.
Apache License 2.0
30
stars
9
forks
source link
Review portable storage implementation.
#2
Closed
jeandudey
closed
6 years ago
jeandudey
commented
6 years ago
Checklist:
[x] Do this implementation binary output matches the one in Monero's epee?
[x] Add test's to verify this it's compatible with Monero.
[x] Also, do this implementation follow the same semantics found in Monero (how portable storage sections are created)?
[x] Do types have good names that reason about theri meaning?
[x] WTF is
ToUnderlying
?, explore an approach using
std
library.
[x] Is it using
failure
optimally?
[x] Review
Bytes
and
BufMut
usage.
[ ] Test the parser never crashes.
Checklist:
ToUnderlying
?, explore an approach usingstd
library.failure
optimally?Bytes
andBufMut
usage.