search

xmtp / XIPs

XMTP Improvement Proposals
Creative Commons Zero v1.0 Universal
44 stars 14 forks source link

404 link in XIP-5 #10

Closed martindufort closed 2 years ago

martindufort commented 2 years ago

The Reference Implementation section provides a link which is not publicly accessible.

galligan commented 2 years ago

@martindufort good call out! We haven't yet made that repo public, but I'll see what we can do to get some Gists up and running in the meantime. Will keep this issue active until it's been resolved.

mkobetic commented 2 years ago

Just to make it clear, the implementation has been merged into the SDK yesterday, so the latest version of the npm package has it.

mkobetic commented 2 years ago

I dumped the diff that was merged into a gist https://gist.github.com/mkobetic/949157c79807286c32bf466968248556

galligan commented 2 years ago

Just to make it clear, the implementation has been merged into the SDK yesterday, so the latest version of the npm package has it.

@mkobetic does this mean this issue can be closed?

mkobetic commented 2 years ago

Just to make it clear, the implementation has been merged into the SDK yesterday, so the latest version of the npm package has it.

@mkobetic does this mean this issue can be closed?

I believe the link in question was https://github.com/xmtp/xmtp-js/pull/68 (from the XIP), and since we made xmtp/xtmp-js repo public, I'd say this should be resolved.