search

xmtp / didethresolver

XMTP Registry Resolver
MIT License
3 stars 1 forks source link

Make docker build fail if clippy complains #27

Closed insipx closed 9 months ago

insipx commented 9 months ago

If clippy finds some improvements to make to the code, the docker build will still succeed. This PR makes the docker build fail on clippy warnings. I think clippy suggestions are still useful as a tool, especially as the team ramps up on rust use so it makes sense to fail the build on PRs where clippy has suggestions

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@e800580). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ======================================= Coverage ? 91.79% ======================================= Files ? 11 Lines ? 1194 Branches ? 0 ======================================= Hits ? 1096 Misses ? 98 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.