search

xmtp / didethresolver

XMTP Registry Resolver
MIT License
3 stars 1 forks source link

Normalize bytes rather than storing hex representation of bytes #49

Closed insipx closed 7 months ago

insipx commented 8 months ago

We were passing b"0xdead" to set_attribute instead of the bytes via Bytes::from_hex leading to issues with attribute values.

cleaned up integration tests a bit by creating set_attribute and revoke_attribute functions

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fb93d06) 97.24% compared to head (4dc4a71) 97.25%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ======================================= Coverage 97.24% 97.25% ======================================= Files 13 13 Lines 3054 3056 +2 ======================================= + Hits 2970 2972 +2 Misses 84 84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.