search

xmtp / example-notification-server-go

Example push notification server, written in Golang
MIT License
15 stars 8 forks source link

Bug: when the delivery service fails for one request we should continue with the rest #44

Closed neekolas closed 4 months ago

neekolas commented 4 months ago

Describe the bug

If a message matches multiple subscriptions, if any of the delivery services fail to deliver the message we should not error out of the whole process. Instead we should log a warning and continue with the rest of the subscriptions.

Expected behavior

No response

Steps to reproduce the bug

No response

bwcDvorak commented 4 months ago

Unsure if it's feasible, but the partner that's affected by this suggests we consider retry mechanisms and or a dead letter queue

neekolas commented 4 months ago

Fixed by https://github.com/xmtp/example-notification-server-go/pull/46

neekolas commented 4 months ago

I'd suggest to the partner that retries or a dead letter queue should be implemented as part of the delivery service, which are customizable by the integrator.

Both are a good idea, but probably out of scope for the example server.

marcomele commented 4 months ago

Partner agrees, thank you for the quick fix :)