xmtp / libxmtp

LibXMTP is a shared library encapsulating the core functionality of the XMTP messaging protocol, such as cryptography, networking, and language bindings.
MIT License
42 stars 18 forks source link

Make clear distinctions between DMs & Groups with common Conversation #1130

Open nplasterer opened 2 days ago

nplasterer commented 2 days ago

With DMs being a group under the hood I'm afraid the lines between the two are going to get increasingly more confusing and potentially cause bugs. To make this easier I think we should make very clear distinctions between DMs and Groups with a common interface of Conversation when doing both in the bindings.

Here are some functions that should exist

richardhuaaa commented 2 days ago

This sounds great to me. Do any of these involve breaking changes to the meaning of existing methods?

nplasterer commented 2 days ago

I don't think there is enough meaningful data in the local consent database to warrent a major issue with renaming GROUP_ID to CONVERSATION_ID but that would be the only breaking change.