xmtp / libxmtp

LibXMTP is a shared library encapsulating the core functionality of the XMTP messaging protocol, such as cryptography, networking, and language bindings.
MIT License
47 stars 20 forks source link

Lowercase the address being stored in the client on the node bindings #1265

Closed codabrink closed 2 weeks ago

nplasterer commented 2 weeks ago

Are people who previously logged into node possibly going to not be able to log in now due to inboxId mismatch? This seems fine but I wonder if a better additional fix would be wherever the error is being thrown that we do a check on the 3 different ways to create a inboxId from a string? ChecksumAddress lowercased maybe uppercase and if it finds an inboxId for any of those cases continue otherwise error?