search

xmtp / libxmtp

LibXMTP is a shared library encapsulating the core functionality of the XMTP messaging protocol, such as cryptography, networking, and language bindings.
MIT License
47 stars 20 forks source link

Check against the inbox id derived against the checksum as well #1268

Closed codabrink closed 1 week ago

codabrink commented 1 week ago

Fixes https://github.com/xmtp/xmtp-react-native/issues/512

It appears that our SDKs at some point allowed or still allow checksum addresses to create inboxIds. Now we have inboxIds on the network that throw a mismatch id error because we handle most addresses as lowercase. This is supposed to prevent any checksum inboxIds from being created ever again and help unblock users with inboxIds that were created from checksum addresses.

rygine commented 1 week ago

@nplasterer i reviewed the WASM/node bindings, and we're already lowercasing where necessary. 🎉

neekolas commented 1 week ago

How many people do we think this issue is affecting?

I'd much rather force them into creating a new identity and shed tech debt rather than having to support this bug forever.

nplasterer commented 1 week ago

The only real person in particular that we know this is effecting is @rygine. But I think a lot of bot accounts and other fresh accounts @humanagent was testing with were also failing but those I think are less important.