xmtp / libxmtp

LibXMTP is a shared library encapsulating the core functionality of the XMTP messaging protocol, such as cryptography, networking, and language bindings.
MIT License
44 stars 19 forks source link

Bug: Remove warning on cross swift bindings build #476

Open cameronvoell opened 8 months ago

cameronvoell commented 8 months ago

Describe the bug

See https://github.com/xmtp/libxmtp/pull/475 for more details

CI for swift bindings has a warning about missing ios/macos architectures, but a fallback to 'cargo' seems to work for now.

Expected behavior

We should figure out why cross does not have the ios architectures available and stop relying on the 'cargo' fallback.

Steps to reproduce the bug

Bug is seen in build.yml GH action: https://github.com/xmtp/libxmtp/actions/runs/7748479132/job/21131172358

Seems to be caused by this step:

https://github.com/xmtp/libxmtp/blob/60ee7556e8c49ec0bf3e2e23c80e8fe4006b11a0/.github/workflows/build.yml#L93-L98

insipx commented 1 month ago

More Context:

https://github.com/xmtp/libxmtp/pull/475#issuecomment-1948853255