search

xmtp / libxmtp

LibXMTP is a shared library encapsulating the core functionality of the XMTP messaging protocol, such as cryptography, networking, and language bindings.
MIT License
42 stars 18 forks source link

Request wallet signature for identity key #74

Closed richardhuaaa closed 1 year ago

richardhuaaa commented 1 year ago

Need to define the Rust interface for requesting this. Additionally, sign the fallback key (using the identity key or the wallet key?)

richardhuaaa commented 1 year ago

Depends on: https://github.com/xmtp/libxmtp/issues/73

neekolas commented 1 year ago

I would think the fallback key would be signed by the identity key, unless we have a strong reason to sign both with the wallet. Every user signature adds friction to the protocol and too many signatures encourages users to tune out and ignore them. We want wallet signatures to be rare enough that they demand attention

jazzz commented 1 year ago

111 Adds support for associating EOAs to Accounts via signatures. The signing mechanism uses an AccountCreator which was designed to facilitate keySigning in wasm -- Wasm is not longer a target so, so a signer could be added in the future but doesn't seem pressing at the moment.