xmtp / libxmtp

MIT License
33 stars 13 forks source link

Legacy key issues #767

Closed neekolas closed 1 month ago

neekolas commented 1 month ago

Summary

I've found issues creating a client with a legacy key. I've created a new test case that reproduces an issue. The legacy key I'm using was exported from xmtp-js.

  1. We are validating that the result of legacy_key_to_address matches the address provided. But legacy_key_to_address returns the XMTP V2 key converted to an eth address, when it should be returning the wallet that signed the XMTP v2 key. I have a fix for that.
  2. Even after that fix, I am seeing Identity(SignatureRequestBuilder(Signature(Invalid))) errors coming from my test case