xmtp / libxmtp

LibXMTP is a shared library encapsulating the core functionality of the XMTP messaging protocol, such as cryptography, networking, and language bindings.
MIT License
41 stars 17 forks source link

Refactor of stream_all_messages, fix flaky stream tests #835

Closed insipx closed 2 months ago

insipx commented 3 months ago

fixes #772

Fixes most of the flaky tests, except for test_can_stream_group_messages_for_updates and test_can_stream_and_update_name_without_forking_group which are unrelated to the stream changes, and instead one of them suffers from the dblock issue (although only in CI), and the other is problematic I think b/c of publish_intents conflicts (also only in CI).

insipx commented 2 months ago

I think we need to propagate some changes up to the mobile SDK's, now that the stream methods are synchronous?

Yeah there do need to be some minor sdk changes -- mostly from async to sync and one method has an error return removed