search

xmtp / xmtp-dot-org

xmtp.org, powered by Docusaurus
https://xmtp.org
MIT License
11 stars 25 forks source link

Lite mode / dark mode resetting #7

Closed petermdenton closed 2 years ago

petermdenton commented 2 years ago

At various times I can get the lite mode and dark mode to change back and forth without the toggle mechanism. It seems to be dependent on me going to a page that might be on a different domain? i.e. if I go from the homepage to the docs, then back things will reset, but randomly.

@mg0716 - is there a reason lite mode/dark mode can't be a v2? I worry this is a whole set of bugs on its own and if we cross domains we are going to be running into this.

galligan commented 2 years ago

@petermdenton light/dark mode is built into Docusaurus. If there's a problem with it, it's on our end. Very very doubtful there's a live bug with it that we ourselves didn't introduce.

That's why we're rolling back to square one on the different repo, where we re-factor with a solid base. The repo has already been set up and we can hammer the vanilla install with as much testing as we'd like.

From there with each PR we do we can bug test.

petermdenton commented 2 years ago

If we jump sub domains, I.e go from homepage to docs.XMTP.org will it preserve state automatically?

galligan commented 2 years ago

@petermdenton I'm not entirely sure. Haven't set up with subdomains yet, so we can test it out and see.

galligan commented 2 years ago

@petermdenton this should be fixed with the new site revision. https://5fedfa9f.website-9re.pages.dev