search

xmtp / xmtp-dot-org

xmtp.org, powered by Docusaurus
https://xmtp.org
MIT License
11 stars 25 forks source link

Background fade obscures card text on far left and far right (re: Add background fade to left slider arrow) #81

Closed darickdang closed 1 year ago

darickdang commented 2 years ago

Describe the bug When the slider for the "SDK and tools" is scrolled, the left edge is abruptly cutoff. We should add a fade behind the arrow when it is scrolled that would also match the right arrow background behavior.

To Reproduce —

Expected behavior —

Screenshots

CleanShot 2022-09-08 at 14 52 10@2x

Additional context —

jhaaaa commented 2 years ago

Not required for release. Fix after release so that we can use the scrolling module once we need to display more than 3 cards.

jhaaaa commented 2 years ago

The background fade is obscuring some of the card text - this is a corner case right now applying to a narrow range of screen widths between desktop and mobile. On desktop, the cards fit without the slider. On mobile, the cards stack. In this mid-range, the slider displays:

image

We'll need to fix this for when we have four cards and the slider will display for desktop and mid-range.

jhaaaa commented 2 years ago

As a part of this work, let's verify that this fix is still in place and working as expected: https://github.com/xmtp/xmtp-dot-org/issues/98

jhaaaa commented 1 year ago

Addressed in https://github.com/xmtp/xmtp-dot-org/pull/195