fix: Correctly handle empty/undefined fallbacks

xmtp / xmtp-react-native

A package you can use to build with XMTP in a React Native or Expo app.

MIT License

35 stars 14 forks source link

fix: Correctly handle empty/undefined fallbacks #341

Closed alexrisch closed 3 months ago

alexrisch commented 3 months ago

Swift/Kotlin protos always set a default value for optional fields this results in differences between sdks and no real way for an undefined value to be returned even if it is expected and typed

Updated to check if there is a fallback, if there is use it, if not set back to undefined Closes: https://github.com/xmtp/xmtp-react-native/issues/337

nplasterer commented 3 months ago

Linking this context for future reference https://github.com/protocolbuffers/protobuf/issues/11790#issuecomment-1416495361

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 1.29.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 1.30.0-beta.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: