xmtp / xmtp-react-native

A package you can use to build with XMTP in a React Native or Expo app.
MIT License
43 stars 21 forks source link

Feature request: Extends the max clients on a group chat #545

Open Doublemme opened 1 week ago

Doublemme commented 1 week ago

Is your feature request related to a problem?

Actually as far as I know there is a limit to 400 clients in a group chat

Describe the solution to the problem

If possibile, remove the limitation on the group chat

Describe the uses cases for the feature

I need to create groups that does not have any limitations on the numbers of clients that can join them because it works like subscriptions channel to send news to people that subscribes them

nplasterer commented 1 week ago

👋 Hey @Doublemme thanks for reaching out. Would love to know more about what you're building. With a subscription channel would it be only a few people that can write and most all the other members are read only?

The MLS limit of members in a group is currently 20,000. We hope to increase our number from 400 to something closer to 20,000 in the future but need to make sure performance is not impacted. We ran into performance issues around 400 so decided to cap it at that for now until we can make sure groups continue to function as intended above 400. Since every member in a group can read and write the complexity of the node tree grows as members are added or removed. If your intention is to have a broadcast channel where only a few members write and everyone else reads only that's an interesting MLS issue we have roadmapped to look into.

Doublemme commented 1 week ago

Hey @nplasterer 👋🏻 , thanks for your quick reply! The feature I'm working on is not completely designed so I don't have an answer regarding the users can write or not in a subscription channel (but I think they aren't allowed to do that).

Thanks for the technical explanation you provided me about the performance issues and for sure I'll keep an eye on the broadcast channel you have roadmapped

Doublemme commented 1 week ago

Hey @nplasterer I have some questions about the broadcast channels and about the increase in the number of members for group chat.

  1. [Broadcast Channels] - There is some Milestone or can you link me the specific issue about implementing that feature?
  2. [Broadcast Channels] - It's an high priority issue or do you have some deadline on that?
  3. [Group chat limit] - The increasing of group chat members have an high priority and a deadline? Or at least a technical analysis on that?

If there are specific issues related to the previous questions and you can provide me these link so I can follow the development of these feature I would appreciate it.

Thanks in advance

nplasterer commented 1 week ago

Hey! Yes going to tag in our @saulmc who drives a lot of our product decisions for timing and deadlines. Here is the issue for group chat limit: https://github.com/xmtp/libxmtp/issues/701 Here is the issue for subscribe & broadcast: https://github.com/xmtp/libxmtp/issues/1077

We plan to have a solution for subscribe and broadcast atleast for dms by the end of the year or early next year to support subscribe & broadcasters who were on the V2 network migrating to V3. As for broadcast channels in groups it's something @mchenani will likely work on in Q2 next year so a little further out. Increasing the ability to grow group size limit could be a nice side effect of other performance improvements we're doing through the end of the year but is not a priority as most groups that are not broadcast groups likely will be fine staying under 400. If we were to try and increase this limit again it would likely be incremental and small. Nothing close to 20k.

Doublemme commented 1 week ago

Thanks for the roadmap explanation I'll keep an eye on these two issues!