search

xmtp / xps-gateway

XPS (XMTP Postal Service) JSON-RPC for xmtp-specific interactions with decentralized networks
https://xmtp.github.io/xps-gateway/
MIT License
2 stars 1 forks source link

---Add support for grant_installation--- #31

Closed tsachiherman closed 8 months ago

tsachiherman commented 8 months ago

What ?

This PR adds support for registering a new installation.

Design considerations

The xps-gateway is the executable endpoint, that manages the rpc endpoint. It will setup an rpc server that would listen for incoming requests and perform input validation. Valid requests would be forwarded to the inbox / messaging / registry crates for method-specific implementation.

Requirements

This PR followed the design details in https://github.com/xmtp/xps-gateway/issues/22; discussion in https://github.com/xmtp/xps-gateway/discussions/13 and https://github.com/xmtp/libxmtp/discussions/274

codecov[bot] commented 8 months ago

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (77a1a11) 60.71% compared to head (777685b) 28.09%.

Files Patch % Lines
xps-gateway/src/rpc/methods.rs 0.00% 43 Missing :warning:
registry/src/registry.rs 0.00% 16 Missing :warning:
xps-gateway/src/lib.rs 0.00% 4 Missing :warning:
xps-gateway/src/types.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #31 +/- ## =========================================== - Coverage 60.71% 28.09% -32.62% =========================================== Files 9 10 +1 Lines 56 121 +65 =========================================== Hits 34 34 - Misses 22 87 +65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsachiherman commented 8 months ago

disbanded in favor of https://github.com/xmtp/xps-gateway/pull/35