xmtp / xps-gateway

XPS (XMTP Postal Service) JSON-RPC for xmtp-specific interactions with decentralized networks
https://xmtp.github.io/xps-gateway/
MIT License
2 stars 1 forks source link

Some bugs during demo development #66

Closed insipx closed 7 months ago

insipx commented 7 months ago
codecov[bot] commented 7 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (18f851d) 91.16% compared to head (938199d) 89.86%.

Files Patch % Lines
registry/src/lib.rs 33.33% 10 Missing :warning:
lib-xps/src/lib.rs 0.00% 2 Missing :warning:
xps/src/main.rs 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== - Coverage 91.16% 89.86% -1.31% ========================================== Files 12 12 Lines 419 444 +25 ========================================== + Hits 382 399 +17 - Misses 37 45 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

insipx commented 7 months ago

It's already merged but would like to point out that registry-localnet could be renamed to localnet because we might add more deployed smart contracts there. otherwise lgtm

I actually gotta do a follow up anyway because i screwed up the DID_REGISTRY address, good callout!