search

xmunoz / sodapy

Python client for the Socrata Open Data API
MIT License
402 stars 114 forks source link

Add discovery API parameters #53

Closed remram44 closed 5 years ago

remram44 commented 5 years ago

Fixes #51

This adds all the parameters supported by the discovery API, except the "domain-specific metadata".

I had to manually figure out which parameters are accepted multiple times and which are not. In addition, it seems that some Socrata instances don't correctly accept repeated fields (only use last value), for example data.cityofnewyork.us (might be due to a reverse-proxy, or a different version of software?)

I am not sure how to add tests for this.

remram44 commented 5 years ago

Little friendly bump before the holidays :wink:

Do you need me to make changes? Thanks!

xmunoz commented 5 years ago

As for unit tests. Take a look at the tests/ directory. The type of tests that I believe need to be added: 1) Check that an exception is raised if an invalid kwarg is passed. 2) Check that valid kwargs have the correct type, if not, raise exception

xmunoz commented 5 years ago

Sorry about the delay. This is fine. I'm merging this.