xmyno / Broker_WorldQuests

World of Warcraft addon for displaying world quests in list form.
http://www.wowinterface.com/downloads/info23964-Broker_WorldQuests.html
MIT License
11 stars 11 forks source link

Shadowlands support #48

Closed xmyno closed 1 year ago

xmyno commented 4 years ago

World Quest Unlock

World Quests are available on the following conditions

Rewards

Filters

Bounty

Achievements

yoshimo commented 4 years ago

We need to also make sure that 51 is the lowest possible level for wqs. I reached 51 on a few chars after coming to bastion. Could have been "play main story" as well though.

yoshimo commented 4 years ago

Thanks to wowhead i think that part becomes easy https://shadowlands.wowhead.com/achievement=14807/hidden-completed-shadowlands-story-dnt-account mentions

Once earned, a player's alt can access the Shadowlands Time Skip mode. (DNT)

I would either check for the achievement or Quest: 62706

https://shadowlands.wowhead.com/achievement=14811/hidden-shadowlands-alt-launch-chromie-if-shadowlands-in-progress-dnt / Quest: 62713 is probably something else.

To see which quest needs to be done to complete the "WQ Unlock Quest ", aka 57559 maybe we could check these:

G[62017]='' -- Yoshimo: probably NECROLORDS COVENANT
G[62019]='' -- Yoshimo: probably NIGHT FAE COVENANT
G[62020]='' -- Yoshimo: probably VENTHYR COVENANT
G[62023]='' -- Yoshimo: probably KYRIAN COVENANT

or maybe C_Covenants.GetActiveCovenantID() , although i don't know which number which covenant is yet

yoshimo commented 4 years ago

Venthyr/Revendreth Unlock https://shadowlands.wowhead.com/quest=59324/our-true-purpose

Necro Lords/Maldraxxus Unlock: https://shadowlands.wowhead.com/quest=59609/urgently-needed

Kyrian/Bastion Unlock https://shadowlands.wowhead.com/quest=57904/return-to-adrestes

Night Fae/Ardenweald Unlock https://shadowlands.wowhead.com/quest=58160/for-queen-and-grove

Not sure how reliable this is as it comes from early beta testing and some parts of the covenant chain were changed since then.

yoshimo commented 4 years ago

Should look something like this

            if IsQuestFlaggedCompleted(62017) then  --Necro Lords/Maldraxxus
                level = "60"
                quest = "|cffffff00|Hquest:59609:-1|h[No Rest For the Dead]|h|r" 
            elseif IsQuestFlaggedCompleted(62019) then --Night Fae/Ardenweald 
                level = "60"
                quest = "|cffffff00|Hquest:58160:-1|h[For Queen and Grove!]|h|r"
            elseif IsQuestFlaggedCompleted(62020) then --Venthyr/Revendreth
                level = "60"
                quest = "|cffffff00|Hquest:59324:-1|hOur True Purpose]|h|r"
            elseif IsQuestFlaggedCompleted(62023) then -- Kyrian/Bastion
                level = "60"
                quest = "|cffffff00|Hquest:57904:-1|h[Our Eternal Charge]|h|r"
            else
                level = "50"
                quest = "[TBD]"
            end
        end
xmyno commented 4 years ago

The world quest unlock spell has only 2 quests listed but maybe that's incomplete.

(there's also this one which has nothing listed: https://shadowlands.wowhead.com/spell=344241/world-quests)

yoshimo commented 4 years ago

The quest rewards for various covenant quests are also incomplete or wrong. The Necrolords campaign changed class specific quests and rewards around a lot. https://github.com/smaitch/Grail/issues/202 has a couple of recordings from various points in time on the beta realm.

For a second indicator of a lower level alt that skipped the main chain and levels with world quests active we might be able to use

  "+ Die Fäden des Schicksals(62704) <= Schicksalsschreiber Ro-Tahl(174871) 1670:20.41,50.28", -- [76]
      "\"threads of fate\" chosen, skip main story", -- [77]
      "New quest completed 58117 UNKNOWN NAME", -- [145]

Every other quest completed with that selection is completed outside Oribos while leveling

yoshimo commented 4 years ago

My old pictures on the topic: WQ_UNLOCK_Bastion_Kyrian WQ_UNLOCK_Maldraxxus_NecroLords WQ_UNLOCK_Revendreth_Venthyr WQ_UNLOCK_Ardenweald_NighFae

Spell data and names are partially out of date, but it should still be close to the current state.

yoshimo commented 4 years ago

I don't remember exactly the conditions but didn't we have a green paw icon for pet battle world quests back in BFA?

xmyno commented 4 years ago

I don't remember exactly the conditions but didn't we have a green paw icon for pet battle world quests back in BFA?

Fixed. Typoed the all uppercase id in Blizzard code 😐 0ff692d6

yoshimo commented 3 years ago

We can filter rewards that contain anima by using C_Item.IsAnimaItemByID(itemlink) on the reward as there are quite a few items with varying amounts of anima rewarded. Maybe by getting the spell link, even high/low.

Amadeus- commented 1 year ago

@yoshimo I think that everything for Shadowlands is now implemented into the addon. If not, please feel free to open a new issue at the new "official" repository at https://github.com/Amadeus-/Broker_WorldQuests. Or, you can fork that repository and create a pull request against it.

We're now at version 10.0.2.3 on Curseforge, which is now associated with my repo linked above.