search

xnbox / DeepfakeHTTP

DeepfakeHTTP is a web server that uses HTTP dumps as a source for responses.
MIT License
513 stars 46 forks source link

Refactoring and tests #5

Open mjablecnik opened 3 years ago

mjablecnik commented 3 years ago

Hello @xnbox I found your DeebfakeHTTP project here and it looks very nice :+1: You created nice tool with good documentation and probably I will be use it ;-)

But when I look into your code so I can really recommend you to read Clean Code book by Robert C. Martin. Because I found that you need it.

Then I really recommend you to go through your projects and made refactor because in DeepfakeHttpServlet you have very big doDbRequest function which can be splited into more smaller functions for better readability. I tried understand it for future contribution but it is very hard to read and understand for me..

The same you can make also in your other projects for example BrowserWindow.java intommybox project you have really big launch function or createMenu function..

Also you should create some tests for ensure that after your refactor works everything right.

Without this changes will be very hard for other developers like me to understand your code and make some changes and PRs in the future..

I hope it will be improved and your project will be successful in the Open Source world. ;-)

xnbox commented 3 years ago

Hi Martin, thanks for the thoughtful code reading and your advice! You're certainly right, doDbRequest is too complex and performs several functions at once, which is not good. The same applies to BrowserWindow.java Your remarks motivate me to refactor this code! I put it on my TODO list. 👍 And yes, I will definitely add tests! Thank you!