search

xnih / satori

Python rewrite of passive OS fingerprinting tool
GNU General Public License v2.0
153 stars 25 forks source link

PY_SSIZE_T_CLEAN message on live capture #8

Closed xnih closed 4 years ago

xnih commented 4 years ago

Warning on startup when doing a live capture: satori.py:254: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats (header, buf) = preader.next()

xnih commented 4 years ago

This seems to have been introduced with Python 3.8 RC something or other.

https://docs.python.org/3/c-api/intro.html

Satori doesn't make any calls directly to C API's, but it calls pcapy.open_live to read the live interface in the section of code where this warning pops: preader = pcapy.open_live(interface, 65536, False, 1)

Therefor I'm assuming this is a pcapy issue to address, but am not 100% sure. Though at this point in time it doesn't limit the ability of the program to function, so I'm ignoring it.

The current version of pcapy is 0.11.4 on Ubuntu 20 at least based on what pip3 finds. May have to revisit how we're doing live stuff in the future if this ends up causing issues and pcapy is why and this doesn't get fixed.