search

xnuinside / gino-admin

Admin Panel for GinoORM - ready to up & run (just add your models)
https://gino-admin.readthedocs.io/en/latest/
MIT License
49 stars 9 forks source link

Unable to run with uvloop #37

Closed rafmagns-skepa-dreag closed 3 years ago

rafmagns-skepa-dreag commented 3 years ago

Hey there! This is shaping up to be super useful for me. Thanks for your hard work!

I tried to add this to my Sanic app and then to start it up with uvloop. It gives me an error because gino_admin.core.add_admin_panel tries to run it's own asyncio loop. I noticed that the function that it calls doesn't seem to have any async components. Would you accept a patch to remove the asyncio call and change gino_admin.users.add_users_model to a synchronous function?

xnuinside commented 3 years ago

@rafmagns-skepa-dreag , hi! Interesting that I did not reproduce this error and this is why I did not catch it :/ but I understand the reason. Yes, I will update code and remove it.

xnuinside commented 3 years ago

@rafmagns-skepa-dreag please test version 0.2.4, I released the fix

rafmagns-skepa-dreag commented 3 years ago

works great. Thanks!