[Android BootCamp]Project 2: NYTimes Search- Ready for Review

[xnxky]

My project is complete, Please review : /cc @codepathreview @codepath

There are still something I could do if I had more time, like using a DatePickerDialog instead of embedded datePicker in the settings DialogFragment, adding sidebar to change the number of columns in the search view and etc.

Some issues that took me time:

• Gson : jsonschema2pojo did not generate correct POJOs, like byline in Doc class, which should be an object, but created as list
• Glide : Could not dynamically resize height, ending up with a defined height
• Recycler View: the animation instruction is not quite right to achieve the given result, using recyclerview-animators. RecyclerView.Adapter should be used instead of itemAnimator as instructed.

[codepathreview]

:+1: Excellent work. A few notes after checking out the code:

• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Nice to see you added the search box to the ActionBar!
• Properly used checkboxes/spinners (with populated values) to allow users to select filters
• Good to see you used a filters object to represent the filters to apply to the query
• Nice job adding the share intent to the article detail view!
• Good job adding progress bars to your app whenever a network request goes out

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.