Closed henlue closed 2 years ago
Data type formatting is now implemented for postgres, mysql and sqlserver.
I've also included the ReadinessURL fix for the sqlserver tests. On my machine the tests now at least work if I include --cleanup=false
. Without the flag they still fail though. The problem is that while the code checks if the sakila schema is there, it is not checking whether all tables have actually been created already.
To fix this properly I would propose to execute the commands from sql-server-sakila-schema.sql
directly from the go testing code and not through a separate shell command. Like this it will be obvious to the testing code when the database initialization has finished, and it would reduce complexity, because building docker images for the tests would not be necessary anymore.
Anyways, since this would be a bigger change, I would propose to do this as a separate PR and close this PR in the current state. @nineinchnick
Implements #177
Adds a
dataTypeFormatter
function to theInformationSchema
reader. The function builds the datatype string from ametadata.Column
object.Only working for the postgres driver so far. For the interval type the fields (second, year ...) are not printed. But this is unrelated to this PR.
@nineinchnick