xo / usql

Universal command-line interface for SQL databases
MIT License
9.07k stars 352 forks source link

Comments not respected in usqlrc #493

Closed glensc closed 1 week ago

glensc commented 1 week ago

In the example, "#" is used for comments:

but having "commented out" echo in config, would still execute it:

❯ head -n1 ~/.usqlrc
#\echo WELCOME TO THE JUNGLE `date`
❯ usql
WELCOME TO THE JUNGLE Tue Nov 12 22:19:14 EET 2024

Type "help" for help.

(not connected)=>  
kenshaw commented 1 week ago

Are you using master at the moment? I'm currently reworking command processing.

kenshaw commented 1 week ago

Please use -- in .usqlrc if you want to continue using ~/.usqlrc -- I would suggest switching to the config.yaml file, however. The part in the README.md is a typo/error on my part, which I'll push a change to shortly.

glensc commented 1 week ago

x-ref the commit made:

ps: you can refer to tickets if you include their id in commit message: "#493"

glensc commented 1 week ago

I installed from brew, version:

❯ usql --version
usql 0.19.12