search

xoac / rust-azure-pipelines

Collection of azure pipelines templates for rust
MIT License
44 stars 12 forks source link

Support releases for macOS #9

Closed xoac closed 5 years ago

nbigaouette commented 5 years ago

Was about to open an issue for that! :D Thanks

nbigaouette commented 5 years ago

Also, I wanted to ask... It seems the releases are built using cross to cross-compile for the different platforms.

Wouldn't it be better if those releases were built on native platforms instead? Azure Pipelines do support those...

nbigaouette commented 5 years ago

Windows build seems broken too. See for example: https://dev.azure.com/nbigaouette/pycors/_build/results?buildId=39

xoac commented 5 years ago

@nbigaouette It's not broken -- it's not supported. But I think I can support this by agent exactly the same as for macOS

nbigaouette commented 5 years ago

I've looked at how the gh release template and the build template worked to create a hard coded release job. See it here: https://github.com/nbigaouette/pycors/blob/4801f1b6b8a45e5ccd8082b514d8b0367ef99e9d/azure-pipelines.yml#L130-L199

This release was crafted using this.

The only issue I see is that it doesn't build a linux musl static binary, only a linux-gnu one.

This approach doesn't use cross though as your template does.

xoac commented 5 years ago

I will use cross to build targets. I will just support additionally Windows and macOS. Sorry so long to implement that. I will try do it today evening but it can potentially take more than one day.

nbigaouette commented 5 years ago

No worries! I'm grateful about your work which saved me a lot of time, so thank you!

xoac commented 5 years ago

@nbigaouette Do u use macOS? if yes can u confirm this binary print hello world?

nbigaouette commented 5 years ago

Yes, hello world works fine.

> ./rust-azure-pipelines
Hello, world!